Fix for half conversion for ROCm 1.8.2#9663
Closed
ashishfarmer wants to merge 1 commit intopytorch:masterfrom
ashishfarmer:rocm1.8.2_half_fix
Closed
Fix for half conversion for ROCm 1.8.2#9663ashishfarmer wants to merge 1 commit intopytorch:masterfrom ashishfarmer:rocm1.8.2_half_fix
ashishfarmer wants to merge 1 commit intopytorch:masterfrom
ashishfarmer:rocm1.8.2_half_fix
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: This PR contains the change for explicit conversion between ushort and __half required for ROCm 1.8.2 support bddppq Pull Request resolved: pytorch#9663 Differential Revision: D8943937 Pulled By: bddppq fbshipit-source-id: 16102f9dbc68ed4ece2e8fc244825c3992c24901
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This PR contains the change for explicit conversion between ushort and __half required for ROCm 1.8.2 support bddppq Pull Request resolved: pytorch#9663 Differential Revision: D8943937 Pulled By: bddppq fbshipit-source-id: 16102f9dbc68ed4ece2e8fc244825c3992c24901
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the change for explicit conversion between ushort and __half required for ROCm 1.8.2 support
@bddppq