Support n-dimensional empty tensors in CUDA non-reduction dimension f…#9658
Closed
gchanan wants to merge 1 commit intopytorch:masterfrom
Closed
Support n-dimensional empty tensors in CUDA non-reduction dimension f…#9658gchanan wants to merge 1 commit intopytorch:masterfrom
gchanan wants to merge 1 commit intopytorch:masterfrom
Conversation
…unctions. This also unifies the error checkign between scatter/scatterAdd on CUDA.
Contributor
Author
|
I wasn't consistent about putting things in if blocks vs returning early; I generally prefer if blocks (even if causes history churn) because it's less likely to have bugs going forward. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@pytorchbot retest this please |
Contributor
Author
|
@pytorchbot retest this please. |
ezyang
reviewed
Jul 23, 2018
| ptrdiff_t numSlices = inElements / sliceSize; | ||
| if (inElements > 0) { | ||
| int64_t sliceSize = THCudaLongTensor_size(state, t, dim); | ||
| ptrdiff_t numSlices = inElements == 0 ? 0 : inElements / sliceSize; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Jul 23, 2018
| "Input tensor must have same size as output tensor apart from the specified dimension"); | ||
| } | ||
| int64_t indexSizeD = THCudaLongTensor_size(state, index, d); | ||
| if (d != dim) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Jul 23, 2018
| } | ||
| THArgCheck(indexSizeD <= THCTensor_(size)(state, src, d), 3, | ||
| "Index tensor must not have larger size than input tensor, but got index %s input %s", | ||
| THCudaLongTensor_sizeDesc(state, index).str, THCTensor_(sizeDesc)(state, src).str); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Jul 23, 2018
|
|
||
| if (THCTensor_(_nDimension)(state, key) == 0) { | ||
| if (inElements == 0) { | ||
| // Zero-dim tensor; do nothing |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
nits will be fixed in an upcoming PR. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 23, 2018
…… (#9658) Summary: …unctions. This also unifies the error checkign between scatter/scatterAdd on CUDA. Pull Request resolved: pytorch/pytorch#9658 Differential Revision: D8941527 Pulled By: gchanan fbshipit-source-id: 750bbac568f607985088211887c4167b67be11ea
gchanan
added a commit
to gchanan/pytorch
that referenced
this pull request
Jul 23, 2018
…m ops. Continuation of pytorch#9658.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 24, 2018
…… (#9722) Summary: …m ops. Continuation of pytorch/pytorch#9658. Pull Request resolved: pytorch/pytorch#9722 Differential Revision: D8956321 Pulled By: gchanan fbshipit-source-id: 116fcaa1be5b1373f03217911556a28125cc860d
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
pytorch#9658) Summary: …unctions. This also unifies the error checkign between scatter/scatterAdd on CUDA. Pull Request resolved: pytorch#9658 Differential Revision: D8941527 Pulled By: gchanan fbshipit-source-id: 750bbac568f607985088211887c4167b67be11ea
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
pytorch#9722) Summary: …m ops. Continuation of pytorch#9658. Pull Request resolved: pytorch#9722 Differential Revision: D8956321 Pulled By: gchanan fbshipit-source-id: 116fcaa1be5b1373f03217911556a28125cc860d
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
pytorch#9658) Summary: …unctions. This also unifies the error checkign between scatter/scatterAdd on CUDA. Pull Request resolved: pytorch#9658 Differential Revision: D8941527 Pulled By: gchanan fbshipit-source-id: 750bbac568f607985088211887c4167b67be11ea
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
pytorch#9722) Summary: …m ops. Continuation of pytorch#9658. Pull Request resolved: pytorch#9722 Differential Revision: D8956321 Pulled By: gchanan fbshipit-source-id: 116fcaa1be5b1373f03217911556a28125cc860d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…unctions.
This also unifies the error checkign between scatter/scatterAdd on CUDA.