quick patch for PackPadded removal to propagate the correct size.#9657
Closed
anderspapitto wants to merge 1 commit intopytorch:masterfrom
Closed
quick patch for PackPadded removal to propagate the correct size.#9657anderspapitto wants to merge 1 commit intopytorch:masterfrom
anderspapitto wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
|
let's try this again. added nullptr check |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@anderspapitto has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@pytorchbot retest this please |
7f4527b to
af26dfe
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@anderspapitto has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Jul 23, 2018
Summary: The underlying reason why this is even an issue is that the conversion into and out of the 'fictional' onnx operators is done in an unhygenic order. This doesn't address that, but it does fix the one observable case where this produces an incorrect result, and unblocks some other work being done.
af26dfe to
76f2819
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@anderspapitto has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
…torch#9657) Summary: The underlying reason why this is even an issue is that the conversion into and out of the 'fictional' onnx operators is done in an unhygenic order. This doesn't address that, but it does fix the one observable case where this produces an incorrect result, and unblocks some other work being done. Pull Request resolved: pytorch#9657 Differential Revision: D8940824 Pulled By: anderspapitto fbshipit-source-id: ea827a24c85447fe4ae470336a746329598eee84
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…torch#9657) Summary: The underlying reason why this is even an issue is that the conversion into and out of the 'fictional' onnx operators is done in an unhygenic order. This doesn't address that, but it does fix the one observable case where this produces an incorrect result, and unblocks some other work being done. Pull Request resolved: pytorch#9657 Differential Revision: D8940824 Pulled By: anderspapitto fbshipit-source-id: ea827a24c85447fe4ae470336a746329598eee84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The underlying reason why this is even an issue is that the conversion
into and out of the 'fictional' onnx operators is done in an unhygenic
order. This doesn't address that, but it does fix the one observable
case where this produces an incorrect result, and unblocks some other
work being done.