Allow MKLDNN on macOS, and any other OS where CMake is able to detect it.#9638
Closed
resistor wants to merge 1 commit intopytorch:masterfrom
Closed
Allow MKLDNN on macOS, and any other OS where CMake is able to detect it.#9638resistor wants to merge 1 commit intopytorch:masterfrom
resistor wants to merge 1 commit intopytorch:masterfrom
Conversation
Collaborator
|
cc: @cpuhrsch do you remember or know why we disabled MKLDNN on non-Linux platforms? |
Contributor
Author
|
@soumith Looking through commit history, it was never explicitly disabled. The code was originally authored as Linux-only, and then Windows support was added. |
soumith
approved these changes
Jul 20, 2018
Contributor
|
@soumith - No, that code was before my time. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
… it. Summary: Pull Request resolved: pytorch#9638 Reviewed By: soumith Differential Revision: D8946130 Pulled By: resistor fbshipit-source-id: 87bd9cb12608467b05bd4998fdb00bfdbd038ca2
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
… it. Summary: Pull Request resolved: pytorch#9638 Reviewed By: soumith Differential Revision: D8946130 Pulled By: resistor fbshipit-source-id: 87bd9cb12608467b05bd4998fdb00bfdbd038ca2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.