Fix hooks handling for unpickled nnmodule#96224
Closed
wconstab wants to merge 1 commit intogh/wconstab/125/basefrom
Closed
Fix hooks handling for unpickled nnmodule#96224wconstab wants to merge 1 commit intogh/wconstab/125/basefrom
wconstab wants to merge 1 commit intogh/wconstab/125/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96224
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c66a5b4: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot merge |
Contributor
Author
Collaborator
Merge failedReason: This PR needs a label If not, please add the For more information, see Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
This appears to have regressed opacus_cifar |
Contributor
|
@pytorchbot revert -c nosignal "inductor regression" |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
|
@pytorchbot revert -m "inductor regression" -c nosignal |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
Collaborator
|
@wconstab your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Mar 8, 2023
This reverts commit 8ca264e. Reverted #96224 on behalf of https://github.com/ezyang due to inductor regression
wconstab
added a commit
that referenced
this pull request
Mar 8, 2023
…(try 2)" Ensure _update_has_hooks() will work regardless of which hook dicts exist on the module. Second try after revert of #96224 where unpickled module didn't have _backward_hooks field. [ghstack-poisoned]
wconstab
added a commit
that referenced
this pull request
Mar 8, 2023
Ensure _update_has_hooks() will work regardless of which hook dicts exist on the module. Second try after revert of #96224 where unpickled module didn't have _backward_hooks field. [ghstack-poisoned]
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Pull Request resolved: pytorch/pytorch#96224 Approved by: https://github.com/albanD
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
This reverts commit 8ca264e. Reverted pytorch/pytorch#96224 on behalf of https://github.com/ezyang due to inductor regression
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Pull Request resolved: pytorch/pytorch#96224 Approved by: https://github.com/albanD
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
This reverts commit 8ca264e. Reverted pytorch/pytorch#96224 on behalf of https://github.com/ezyang due to inductor regression
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Pull Request resolved: pytorch#96224 Approved by: https://github.com/albanD
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
This reverts commit 8ca264e. Reverted pytorch#96224 on behalf of https://github.com/ezyang due to inductor regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):