Skip to content

Fix validate_input_col for nn.Module or Callable#96213

Closed
ejguan wants to merge 2 commits intopytorch:masterfrom
ejguan:fix_validate_input_col
Closed

Fix validate_input_col for nn.Module or Callable#96213
ejguan wants to merge 2 commits intopytorch:masterfrom
ejguan:fix_validate_input_col

Conversation

@ejguan
Copy link
Contributor

@ejguan ejguan commented Mar 7, 2023

Forward fix the problem introduced in #95067

Not all Callable objects have __name__ implemented. Using repr as the backup solution to get function name or reference.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 7, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96213

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 5 Pending

As of commit 6c293ae:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Mar 7, 2023
@ejguan ejguan requested a review from NivekT March 7, 2023 19:27
@ejguan ejguan added the topic: bug fixes topic category label Mar 7, 2023
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ejguan
Copy link
Contributor Author

ejguan commented Mar 7, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 7, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@ejguan
Copy link
Contributor Author

ejguan commented Mar 7, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
Forward fix the problem introduced in pytorch/pytorch#95067

Not all `Callable` objects have `__name__` implemented. Using `repr` as the backup solution to get function name or reference.
Pull Request resolved: pytorch/pytorch#96213
Approved by: https://github.com/NivekT
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
Forward fix the problem introduced in pytorch/pytorch#95067

Not all `Callable` objects have `__name__` implemented. Using `repr` as the backup solution to get function name or reference.
Pull Request resolved: pytorch/pytorch#96213
Approved by: https://github.com/NivekT
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
Forward fix the problem introduced in pytorch#95067

Not all `Callable` objects have `__name__` implemented. Using `repr` as the backup solution to get function name or reference.
Pull Request resolved: pytorch#96213
Approved by: https://github.com/NivekT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: dataloader release notes category topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants