Skip to content

Fix ONNX LogSoftmax export.#9576

Closed
kit1980 wants to merge 1 commit intopytorch:masterfrom
kit1980:master
Closed

Fix ONNX LogSoftmax export.#9576
kit1980 wants to merge 1 commit intopytorch:masterfrom
kit1980:master

Conversation

@kit1980
Copy link
Contributor

@kit1980 kit1980 commented Jul 19, 2018

This fixes an issue with incorrect axis=-1 in the exported ONNX.

@kit1980
Copy link
Contributor Author

kit1980 commented Jul 19, 2018

Now one test is failing on exporting LogSoftmax model, but without this change it exports to a wrong ONNX model.

@houseroad
Copy link
Member

#9660 will fix the wrong test cases.

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Let's wait for #9660 to fix the wrong test case.

@zou3519 zou3519 added the module: onnx Related to torch.onnx label Jul 24, 2018
@kit1980
Copy link
Contributor Author

kit1980 commented Aug 1, 2018

#9660 is in now, how can we proceed with this PR?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad
Copy link
Member

@pytorchbot retest this please

@houseroad houseroad closed this Aug 2, 2018
@houseroad houseroad reopened this Aug 2, 2018
@houseroad houseroad closed this Aug 2, 2018
@houseroad houseroad reopened this Aug 2, 2018
@houseroad
Copy link
Member

@kit1980 can you rebase the code to the master?

@kit1980
Copy link
Contributor Author

kit1980 commented Aug 2, 2018

@houseroad rebased on master.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
This fixes an issue with incorrect `axis=-1` in the exported ONNX.
Pull Request resolved: pytorch#9576

Reviewed By: yinghai

Differential Revision: D9125463

Pulled By: houseroad

fbshipit-source-id: 6f4cb1067d1aa6bb0a9f56690fc21816c98eebfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: onnx Related to torch.onnx open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants