Skip to content

ONNXIFI transform#9569

Closed
yinghai wants to merge 7 commits intopytorch:masterfrom
yinghai:onnxifi_transform
Closed

ONNXIFI transform#9569
yinghai wants to merge 7 commits intopytorch:masterfrom
yinghai:onnxifi_transform

Conversation

@yinghai
Copy link
Contributor

@yinghai yinghai commented Jul 18, 2018 •
edited
Loading

Cut-off runnable subgraph and off-load to ONNXIFI backend

Test Plan:

  • Build libtrt_onnxify.so from recent master
  • ln -s /home/yinghai/onnx-tensorrt/build/libtrt_onnxify.so ~/lib/libonnxifi.so
  • export LD_LIBRARY_PATH=/home/yinghai/lib:$LD_LIBRARY_PATH
  • Patch this PR and build Pytorch
  • pytest -s test_onnxifi.py

@yinghai yinghai added the caffe2 label Jul 18, 2018
@yinghai yinghai requested review from Maratyszcza and bddppq July 18, 2018 22:14
bddppq
bddppq reviewed Jul 19, 2018
View reviewed changes
caffe2/operators/onnxifi_op.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/python/onnx/test_onnxifi.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/python/onnx/test_onnxifi.py Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/python/onnx/test_onnxifi.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/python/onnx/test_onnxifi.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/python/onnx/test_onnxifi.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/python/onnx/test_onnxifi.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/onnx/onnxifi_transformer.cc Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/onnx/onnxifi_transformer.cc Outdated

This comment was marked as off-topic.

Sign in to view

@Maratyszcza Maratyszcza changed the title Onnxifi transform ONNXIFI transform Jul 19, 2018
Maratyszcza
Maratyszcza reviewed Jul 19, 2018
View reviewed changes
caffe2/onnx/onnxifi_transformer.cc Outdated

This comment was marked as off-topic.

Sign in to view

Maratyszcza
Maratyszcza reviewed Jul 19, 2018
View reviewed changes
caffe2/onnx/onnxifi_transformer.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Maratyszcza
Maratyszcza reviewed Jul 20, 2018
View reviewed changes
caffe2/onnx/onnxifi_transformer.cc Outdated

This comment was marked as off-topic.

Sign in to view

Maratyszcza
Maratyszcza reviewed Jul 20, 2018
View reviewed changes
caffe2/python/pybind_state.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Maratyszcza
Maratyszcza reviewed Jul 20, 2018
View reviewed changes
caffe2/python/pybind_state.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Maratyszcza
Maratyszcza reviewed Jul 20, 2018
View reviewed changes
caffe2/python/pybind_state.cc Outdated

This comment was marked as off-topic.

Sign in to view

@yinghai yinghai force-pushed the onnxifi_transform branch from 60b4564 to be20b93 Compare July 20, 2018 05:42
facebook-github-bot
facebook-github-bot reviewed Jul 20, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Jul 20, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yinghai
Copy link
Contributor Author

yinghai commented Jul 20, 2018

@pytorchbot retest this please

facebook-github-bot
facebook-github-bot reviewed Jul 20, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yinghai
Copy link
Contributor Author

yinghai commented Jul 20, 2018

pr/caffe2-py2-mkl-ubuntu16.04-test is due to flaky numerics in rnn test. Not related.

facebook-github-bot
facebook-github-bot reviewed Jul 20, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Maratyszcza
Maratyszcza approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@Maratyszcza Maratyszcza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
@jramseyer
ONNXIFI transform (pytorch#9569)
b47e32e 
Summary:
Cut-off runnable subgraph and off-load to ONNXIFI backend
Pull Request resolved: pytorch#9569

Reviewed By: Maratyszcza

Differential Revision: D8930408

Pulled By: yinghai

fbshipit-source-id: 2b494f7f8dc10c00e58cf0fed5c4a9434be6155b
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
ONNXIFI transform (pytorch#9569)
f6b4e12 
Summary:
Cut-off runnable subgraph and off-load to ONNXIFI backend
Pull Request resolved: pytorch#9569

Reviewed By: Maratyszcza

Differential Revision: D8930408

Pulled By: yinghai

fbshipit-source-id: 2b494f7f8dc10c00e58cf0fed5c4a9434be6155b
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

+2 more reviewers

@bddppq bddppq bddppq left review comments

@Maratyszcza Maratyszcza Maratyszcza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

caffe2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yinghai @Maratyszcza @facebook-github-bot @bddppq @ezyang