Add standalone torch._inductor.compile() API#95594
Closed
jansel wants to merge 3 commits intogh/jansel/61/basefrom
Closed
Add standalone torch._inductor.compile() API#95594jansel wants to merge 3 commits intogh/jansel/61/basefrom
jansel wants to merge 3 commits intogh/jansel/61/basefrom
Conversation
This fixes support for inductor compiling non-dynamo generated FX graphs. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95594
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3b936c6: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bertmaher
approved these changes
Feb 27, 2023
Contributor
bertmaher
left a comment
There was a problem hiding this comment.
Cool, thanks for doing this!
desertfire
approved these changes
Feb 27, 2023
Contributor
desertfire
left a comment
There was a problem hiding this comment.
This would also benefit AOT Inductor. Thanks!
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
This fixes support for inductor compiling non-dynamo generated FX graphs. cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
This fixes support for inductor compiling non-dynamo generated FX graphs. cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 2, 2023
This fixes support for inductor compiling non-dynamo generated FX graphs. Pull Request resolved: pytorch/pytorch#95594 Approved by: https://github.com/bertmaher, https://github.com/desertfire
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This fixes support for inductor compiling non-dynamo generated FX graphs. Pull Request resolved: pytorch/pytorch#95594 Approved by: https://github.com/bertmaher, https://github.com/desertfire
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
This fixes support for inductor compiling non-dynamo generated FX graphs. Pull Request resolved: pytorch/pytorch#95594 Approved by: https://github.com/bertmaher, https://github.com/desertfire
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 19, 2023
Op-benchmark directly uses fx.Graph to create nodes without dynamo and then compiles the graph with inductor. Currently, operators with multiple outputs, e.g. native_layer_norm, would fail to run caused by standalone torch._inductor.compile() API #95594. Actually, the graph's result is a node with several outputs instead of a tuple with several nodes. However, the standalone API forces a non-tuple result be a tuple, i.e., a tuple with one node-type element with several outputs. This PR considers a return node with several outputs as a tuple to avoid errors. Pull Request resolved: #96936 Approved by: https://github.com/jgong5, https://github.com/jansel
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 20, 2023
Op-benchmark directly uses fx.Graph to create nodes without dynamo and then compiles the graph with inductor. Currently, operators with multiple outputs, e.g. native_layer_norm, would fail to run caused by standalone torch._inductor.compile() API #95594. Actually, the graph's result is a node with several outputs instead of a tuple with several nodes. However, the standalone API forces a non-tuple result be a tuple, i.e., a tuple with one node-type element with several outputs. This PR considers a return node with several outputs as a tuple to avoid errors. Pull Request resolved: #96936 Approved by: https://github.com/jgong5, https://github.com/jansel
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
This reverts commit e13b804.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This fixes support for inductor compiling non-dynamo generated FX graphs.
cc @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire