Update channel_shuffle_op and transpose 2d to speed up ShuffleNet#9525
Closed
xiaomengy wants to merge 1 commit intopytorch:masterfrom
Closed
Update channel_shuffle_op and transpose 2d to speed up ShuffleNet#9525xiaomengy wants to merge 1 commit intopytorch:masterfrom
xiaomengy wants to merge 1 commit intopytorch:masterfrom
Conversation
de68c2f to
5e3b4fc
Compare
5e3b4fc to
b27c8df
Compare
Contributor
Author
|
@pytorchbot retest this please |
houseroad
reviewed
Jul 19, 2018
caffe2/utils/math_cpu.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@pytorchbot retest this please |
houseroad
approved these changes
Jul 19, 2018
Member
houseroad
left a comment
There was a problem hiding this comment.
The logic LGTM. Please make sure the iOS part is well tested.
Contributor
Author
|
@pytorchbot retest this please |
houseroad
reviewed
Jul 19, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
b27c8df to
de6c726
Compare
Contributor
Author
|
@pytorchbot retest this please |
de6c726 to
11b6ec2
Compare
Contributor
Author
|
Some benchmark: N = 128, C = 128, H = 128, W = 128, group = 4 |
11b6ec2 to
fdfa697
Compare
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
fdfa697 to
0a85f5b
Compare
Contributor
Author
|
@pytorchbot retest this please |
0a85f5b to
60efe59
Compare
Contributor
Author
|
@pytorchbot retest this please |
Member
|
@pytorchbot retest this please |
60efe59 to
c9530fb
Compare
c9530fb to
92e0184
Compare
92e0184 to
c7735e4
Compare
Contributor
Author
|
@pytorchbot retest this please |
c7735e4 to
243fe15
Compare
Contributor
Author
|
@pytorchbot retest this please |
243fe15 to
bd10d0f
Compare
Contributor
Author
|
@pytorchbot retest this please |
bd10d0f to
40cd057
Compare
…torch#9525) Summary: Pull Request resolved: pytorch#9525 Update channel_shuffle_op and transpose 2d to speed up ShuffleNet Reviewed By: houseroad Differential Revision: D8889361 fbshipit-source-id: b5344955acb466e224e1c80cbaca721743c09e2f
40cd057 to
ea995d9
Compare
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
…torch#9525) Summary: Pull Request resolved: pytorch#9525 Update channel_shuffle_op and transpose 2d to speed up ShuffleNet Reviewed By: houseroad Differential Revision: D8889361 fbshipit-source-id: 60196e819b6842becc53b4859b62d4419a0e2c6e
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…torch#9525) Summary: Pull Request resolved: pytorch#9525 Update channel_shuffle_op and transpose 2d to speed up ShuffleNet Reviewed By: houseroad Differential Revision: D8889361 fbshipit-source-id: 60196e819b6842becc53b4859b62d4419a0e2c6e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Update channel_shuffle_op and transpose 2d to speed up ShuffleNet
Differential Revision: D8889361