added reminder of args naming rules to readme#9504
Closed
weiyangfb wants to merge 1 commit intopytorch:masterfrom
Closed
added reminder of args naming rules to readme#9504weiyangfb wants to merge 1 commit intopytorch:masterfrom
weiyangfb wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
weiyangfb
commented
Jul 17, 2018
- I ran into this couple days ago, and thought it might be useful to take note on that
soumith
approved these changes
Jul 18, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 18, 2018
Summary: - I ran into this couple days ago, and thought it might be useful to take note on that Pull Request resolved: pytorch/pytorch#9504 Reviewed By: soumith Differential Revision: D8887396 Pulled By: weiyangfb fbshipit-source-id: d2061cf379ce140d6e43ef6c18241f7ce00dbab6
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: - I ran into this couple days ago, and thought it might be useful to take note on that Pull Request resolved: pytorch#9504 Reviewed By: soumith Differential Revision: D8887396 Pulled By: weiyangfb fbshipit-source-id: d2061cf379ce140d6e43ef6c18241f7ce00dbab6
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: - I ran into this couple days ago, and thought it might be useful to take note on that Pull Request resolved: pytorch#9504 Reviewed By: soumith Differential Revision: D8887396 Pulled By: weiyangfb fbshipit-source-id: d2061cf379ce140d6e43ef6c18241f7ce00dbab6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.