Remove unnecessary TensorMeta rewrap#95004
Closed
ezyang wants to merge 1 commit intogh/ezyang/1825/basefrom
Closed
Remove unnecessary TensorMeta rewrap#95004ezyang wants to merge 1 commit intogh/ezyang/1825/basefrom
ezyang wants to merge 1 commit intogh/ezyang/1825/basefrom
Conversation
Extracted from #94523 Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95004
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 480f66a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
voznesenskym
approved these changes
Feb 16, 2023
ngimel
reviewed
Feb 16, 2023
| utils.validate_dimension_indices(a.ndim, dims) | ||
| out = torch.empty_like(a, memory_format=torch.preserve_format) | ||
| return TensorMeta(out) | ||
| return torch.empty_like(a, memory_format=torch.preserve_format) |
Collaborator
There was a problem hiding this comment.
are there other places with unneeded rewraps?
Contributor
Author
There was a problem hiding this comment.
It looks like this is the only one lol. At least in torch/_prims
ngimel
approved these changes
Feb 16, 2023
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
approved these changes
Feb 16, 2023
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
This reverts commit 0dffbcd.
jhavukainen
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 15, 2024
Extracted from pytorch#94523 Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#95004 Approved by: https://github.com/voznesenskym, https://github.com/ngimel, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Extracted from #94523
Signed-off-by: Edward Z. Yang ezyang@meta.com