Give THTensor a constructor, use new/free.#9496
Closed
ezyang wants to merge 1 commit intopytorch:masterfrom
Closed
Give THTensor a constructor, use new/free.#9496ezyang wants to merge 1 commit intopytorch:masterfrom
ezyang wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gchanan
approved these changes
Jul 17, 2018
Contributor
gchanan
left a comment
There was a problem hiding this comment.
some of this ends up looking a bit silly because of the C heritage, i.e. allocating size [0], and then immediately changing it to the actual size (setStorageNd). We should probably have another constructor, right?
Contributor
Author
|
yeah, agreed |
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 18, 2018
Summary: Stacked on #9495 Pull Request resolved: pytorch/pytorch#9496 Differential Revision: D8875528 Pulled By: ezyang fbshipit-source-id: 6419d2ffb07aaf49c1462e7b64737019abbb7f61
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Stacked on pytorch#9495 Pull Request resolved: pytorch#9496 Differential Revision: D8875528 Pulled By: ezyang fbshipit-source-id: 6419d2ffb07aaf49c1462e7b64737019abbb7f61
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Stacked on pytorch#9495 Pull Request resolved: pytorch#9496 Differential Revision: D8875528 Pulled By: ezyang fbshipit-source-id: 6419d2ffb07aaf49c1462e7b64737019abbb7f61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #9495