Handle the "spatial" attribute in onnx BatchNormalization op#9492
Closed
JerryShih wants to merge 1 commit intopytorch:masterfrom
Closed
Handle the "spatial" attribute in onnx BatchNormalization op#9492JerryShih wants to merge 1 commit intopytorch:masterfrom
JerryShih wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
|
@houseroad @yinghai |
Contributor
Author
|
Any comment for this patch? |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@houseroad |
Member
|
There is a merge conflict, could you update the diff? @JerryShih |
52e74d0 to
63b3f22
Compare
If we have this "spatial" attribute and its value equals to 1, we could just remove this attribute and convert this op to caffe2 SpatialBN.
63b3f22 to
9193ad1
Compare
Contributor
Author
|
@houseroad |
Contributor
|
@pytorchbot retest this please |
Contributor
Author
|
@ezyang @houseroad |
Member
|
yep, retrying |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
…#9492) Summary: If we have this "spatial" attribute and its value equals to 1, we could just remove this attribute and convert this op to caffe2 SpatialBN. Pull Request resolved: pytorch#9492 Differential Revision: D8988165 Pulled By: houseroad fbshipit-source-id: a9218dc9cd5fab43deb371f290f81285f5283231
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…#9492) Summary: If we have this "spatial" attribute and its value equals to 1, we could just remove this attribute and convert this op to caffe2 SpatialBN. Pull Request resolved: pytorch#9492 Differential Revision: D8988165 Pulled By: houseroad fbshipit-source-id: a9218dc9cd5fab43deb371f290f81285f5283231
zoidor
added a commit
to zoidor/MLTests
that referenced
this pull request
Feb 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have this "spatial" attribute and its value equals to 1, we could just remove this attribute and convert this op to caffe2 SpatialBN.