[caffe2] pre-convert filter format in optimizeForIDEEP#9488
Closed
gujinghui wants to merge 1 commit intopytorch:masterfrom
Closed
[caffe2] pre-convert filter format in optimizeForIDEEP#9488gujinghui wants to merge 1 commit intopytorch:masterfrom
gujinghui wants to merge 1 commit intopytorch:masterfrom
Conversation
Collaborator
Author
yinghai
reviewed
Jul 17, 2018
caffe2/opt/converter.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
b0be3fa to
25f2465
Compare
25f2465 to
8b16125
Compare
Collaborator
Author
|
@yinghai rebased. pls review |
8b16125 to
a25879e
Compare
Contributor
|
ping @yinghai |
a25879e to
52f59fc
Compare
Collaborator
Author
Contributor
|
Please split this into 3 PRs as you outlined above. |
Signed-off-by: Gu, Jinghui <jinghui.gu@intel.com>
52f59fc to
ce016a9
Compare
Collaborator
Author
Contributor
|
@gujinghui Is this still relevant? |
Collaborator
Author
|
@yinghai Thanks for reminder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the filters to expected format before computation.