[caffe2] Support grouped filter in conv#12970
Closed
gujinghui wants to merge 1 commit intopytorch:masterfrom
Closed
[caffe2] Support grouped filter in conv#12970gujinghui wants to merge 1 commit intopytorch:masterfrom
gujinghui wants to merge 1 commit intopytorch:masterfrom
Conversation
Signed-off-by: Gu, Jinghui <jinghui.gu@intel.com>
Collaborator
Author
|
@pytorchbot retest this please |
yinghai
reviewed
Oct 23, 2018
Contributor
yinghai
left a comment
There was a problem hiding this comment.
Do we have test cases for grouped filter conv?
Collaborator
Author
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
yinghai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
TBH, I'm not very fond of the the idea about the need of preprocessing of workspace. If anything, we should always have the cached processed tensor inside the operator just in case people run the net without preprocessing it. |
yinghai
suggested changes
Nov 2, 2018
Contributor
yinghai
left a comment
There was a problem hiding this comment.
Please conform your clang-format to pytorch style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support grouped filters which already pre-converted in optimize_ideep.