Add ideep copy for TensorCPU<long> in IDEEPFallbackOp#9480
Closed
vishar0 wants to merge 1 commit intopytorch:masterfrom
Closed
Add ideep copy for TensorCPU<long> in IDEEPFallbackOp#9480vishar0 wants to merge 1 commit intopytorch:masterfrom
vishar0 wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: Pull Request resolved: pytorch#9480 Ops like Reshape sometimes take a second input tensor of long with the new shape (can also be specified in arg). If this input tensor is passed in via external input (which ONNX does sometimes), LoadOp fails with an exception. Such ops anyway are executed by IDEEPFallbackOp, so this should be fine. Reviewed By: yinghai Differential Revision: D8872671 fbshipit-source-id: 2d3ecf39d77deed5fa0c714eebfd73429e6026b3
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch#9480 Ops like Reshape sometimes take a second input tensor of long with the new shape (can also be specified in arg). If this input tensor is passed in via external input (which ONNX does sometimes), LoadOp fails with an exception. Such ops anyway are executed by IDEEPFallbackOp, so this should be fine. Reviewed By: yinghai Differential Revision: D8872671 fbshipit-source-id: 659a02416c374e373ce041a7d65a174be828702d
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9480 Ops like Reshape sometimes take a second input tensor of long with the new shape (can also be specified in arg). If this input tensor is passed in via external input (which ONNX does sometimes), LoadOp fails with an exception. Such ops anyway are executed by IDEEPFallbackOp, so this should be fine. Reviewed By: yinghai Differential Revision: D8872671 fbshipit-source-id: 659a02416c374e373ce041a7d65a174be828702d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Ops like Reshape sometimes take a second input tensor of long with the new
shape (can also be specified in arg). If this input tensor is passed in via
external input (which ONNX does sometimes), LoadOp fails with an exception.
Such ops anyway are executed by IDEEPFallbackOp, so this should be fine.
Reviewed By: yinghai
Differential Revision: D8872671