Add Support for count_include_pad in AveragePool in Caffe2 ONNX Backend#9458
Closed
hl475 wants to merge 1 commit intopytorch:masterfrom
Closed
Add Support for count_include_pad in AveragePool in Caffe2 ONNX Backend#9458hl475 wants to merge 1 commit intopytorch:masterfrom
hl475 wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
|
@houseroad @bddppq, please take a look. Thanks! |
houseroad
reviewed
Jul 16, 2018
caffe2/onnx/backend.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
reviewed
Jul 16, 2018
caffe2/onnx/backend.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
reviewed
Jul 16, 2018
caffe2/onnx/backend.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
hl475
commented
Jul 17, 2018
caffe2/onnx/backend.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
hl475
commented
Jul 17, 2018
caffe2/onnx/backend.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…nd (pytorch#9458) Summary: Pull Request resolved: pytorch#9458 The goal is to support count_include_pad in Caffe2 ONNX backend. This commit contains the first step - support 4-D tensor cases. AveragePool with count_include_pad can be expressed as PadImage + AveragePool. Differential Revision: D8852180 fbshipit-source-id: 1bb9ad484998b6950eadb8c7efbed1e636fb06bf
houseroad
approved these changes
Jul 17, 2018
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Member
|
@pytorchbot retest this please |
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
…nd (pytorch#9458) Summary: Pull Request resolved: pytorch#9458 The goal is to support count_include_pad in Caffe2 ONNX backend. This commit contains the first step - support 4-D tensor cases. AveragePool with count_include_pad can be expressed as PadImage + AveragePool. Reviewed By: houseroad Differential Revision: D8852180 fbshipit-source-id: 4db00e9771be7a000a2d92850dfd066d9c9c38bf
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…nd (pytorch#9458) Summary: Pull Request resolved: pytorch#9458 The goal is to support count_include_pad in Caffe2 ONNX backend. This commit contains the first step - support 4-D tensor cases. AveragePool with count_include_pad can be expressed as PadImage + AveragePool. Reviewed By: houseroad Differential Revision: D8852180 fbshipit-source-id: 4db00e9771be7a000a2d92850dfd066d9c9c38bf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The goal is to support count_include_pad in Caffe2 ONNX backend. This commit contains the first step - support 4-D tensor cases.
AveragePool with count_include_pad can be expressed as PadImage + AveragePool.
Differential Revision: D8852180