Skip to content

[EASY] Pass THDRequest as void* pointer to THDRequest_free#9398

Closed
yf225 wants to merge 1 commit intopytorch:masterfrom
yf225:ubsan_function_fix
Closed

[EASY] Pass THDRequest as void* pointer to THDRequest_free#9398
yf225 wants to merge 1 commit intopytorch:masterfrom
yf225:ubsan_function_fix

Conversation

@yf225
Copy link
Contributor

@yf225 yf225 commented Jul 12, 2018

This fixes #9054.

@yf225 yf225 requested a review from colesbury July 12, 2018 22:18
@yf225 yf225 changed the title Pass THDRequest as void* pointer to THDRequest_free [EASY] Pass THDRequest as void* pointer to THDRequest_free Jul 12, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225
Copy link
Contributor Author

yf225 commented Jul 12, 2018

@pytorchbot retest this please

1 similar comment
@yf225
Copy link
Contributor Author

yf225 commented Jul 13, 2018

@pytorchbot retest this please

zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 17, 2018
Summary:
This fixes pytorch/pytorch#9054.
Pull Request resolved: pytorch/pytorch#9398

Reviewed By: ezyang

Differential Revision: D8827778

Pulled By: yf225

fbshipit-source-id: 862287802cb69c6ac71ff4df19cadb89b1face1d
goldsborough pushed a commit to goldsborough/pytorch that referenced this pull request Jul 20, 2018
Summary:
This fixes pytorch#9054.
Pull Request resolved: pytorch#9398

Reviewed By: ezyang

Differential Revision: D8827778

Pulled By: yf225

fbshipit-source-id: 862287802cb69c6ac71ff4df19cadb89b1face1d
jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
Summary:
This fixes pytorch#9054.
Pull Request resolved: pytorch#9398

Reviewed By: ezyang

Differential Revision: D8827778

Pulled By: yf225

fbshipit-source-id: 862287802cb69c6ac71ff4df19cadb89b1face1d
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
This fixes pytorch#9054.
Pull Request resolved: pytorch#9398

Reviewed By: ezyang

Differential Revision: D8827778

Pulled By: yf225

fbshipit-source-id: 862287802cb69c6ac71ff4df19cadb89b1face1d
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UBSAN error: call to function THDRequest_free through pointer to incorrect function type 'void (*)(void *)'

3 participants