Closed
Conversation
Contributor
Author
|
@Jorghi12 I remember you have an pull request to upstream all these cmake variables to the rocm repo? Could you add this line to it? (if it's already merged I can create another upstream PR) |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Jul 12, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 12, 2018
Summary: petrex To make `-DBUILD_SHARED_LIBS=OFF` working Pull Request resolved: pytorch/pytorch#9394 Reviewed By: mingzhe09088 Differential Revision: D8822947 Pulled By: bddppq fbshipit-source-id: 4fb213c723138804fb0fdb3b381e32623cf14468
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: petrex To make `-DBUILD_SHARED_LIBS=OFF` working Pull Request resolved: pytorch/pytorch#9394 Reviewed By: mingzhe09088 Differential Revision: D8822947 Pulled By: bddppq fbshipit-source-id: 4fb213c723138804fb0fdb3b381e32623cf14468
Contributor
|
@bddppq Here's the upstreamed merge: https://github.com/ROCm-Developer-Tools/HIP/pull/558/files |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: petrex To make `-DBUILD_SHARED_LIBS=OFF` working Pull Request resolved: pytorch#9394 Reviewed By: mingzhe09088 Differential Revision: D8822947 Pulled By: bddppq fbshipit-source-id: 4fb213c723138804fb0fdb3b381e32623cf14468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@petrex
To make
-DBUILD_SHARED_LIBS=OFFworking