Fix/refactor dynamo onnxrt backend by jansel · Pull Request #93818 · pytorch/pytorch

jansel · 2023-02-01T04:52:36Z

Stack from ghstack (oldest at bottom):

cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire

[ghstack-poisoned]

pytorch-bot · 2023-02-01T04:52:39Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93818

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 94cb764:

NEW FAILURES - The following jobs have failed:

cuda11.7-py3.10-gcc7-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

Fixes #90352 cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

voznesenskym · 2023-02-02T22:00:37Z

torch/_dynamo/backends/common.py

+            device=x.device,
+            requires_grad=x.requires_grad,
+        )
+        y.zero_()


zero_ doesn't change the layout set above.

I don't see you passing layout to empty_strided though?

voznesenskym · 2023-02-02T22:01:48Z

torch/_dynamo/backends/common.py

+    return wrapper
+
+
+def device_from_inputs(example_inputs) -> torch.device:


nit: move to utils?

Also - would we ever have multiple devices?

jansel · 2023-02-03T03:37:39Z

@pytorchbot merge

pytorchmergebot · 2023-02-03T03:39:29Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-02-03T03:39:33Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / build

Details for Dev Infra team

Raised by workflow job

Fixes #90352 cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

jansel · 2023-02-03T05:22:04Z

@pytorchbot merge

pytorchmergebot · 2023-02-03T05:23:43Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-02-03T06:54:34Z

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / cuda11.7-py3.10-gcc7-sm86 / test (inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

jansel · 2023-02-03T16:38:19Z

@pytorchbot merge -f "failure not related"

pytorchmergebot · 2023-02-03T16:40:23Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-02-03T16:40:28Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 4d4d2998642a5f3b6892b4884ae9d44669ab1e85 returned non-zero exit code 1

Auto-merging benchmarks/dynamo/common.py
Auto-merging test/dynamo/test_optimizations.py
Auto-merging torch/_dynamo/optimizations/backends.py
CONFLICT (content): Merge conflict in torch/_dynamo/optimizations/backends.py
error: could not apply 4d4d299864... Fix/refactor dynamo onnxrt backend
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

Fixes #90352 cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

jansel · 2023-02-03T16:53:58Z

@pytorchbot merge

pytorchmergebot · 2023-02-03T16:58:37Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-02-03T17:59:15Z

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / cuda11.7-py3.10-gcc7-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

jansel · 2023-02-03T20:46:11Z

@pytorchbot merge -f "unrelated CI timeout"

pytorchmergebot · 2023-02-03T20:47:57Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Fix/refactor dynamo onnxrt backend

eef53af

[ghstack-poisoned]

jansel mentioned this pull request Feb 1, 2023

ConfigModule for _{dynamo,inductor}.config #93252

Closed

pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Feb 1, 2023

github-actions bot added ciflow/inductor module: dynamo labels Feb 1, 2023

This was referenced Feb 1, 2023

Move dynamo.optimizations.distributed to backends #93408

Closed

Refactor dynamo training backends #93409

Closed

Update on "Fix/refactor dynamo onnxrt backend"

e07d05f

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

This was referenced Feb 1, 2023

Rename aot_cudagraphs to cudagraphs #93821

Closed

Remove fx2trt/torch2trt backends #93822

Closed

Update on "Fix/refactor dynamo onnxrt backend"

7308460

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

jansel mentioned this pull request Feb 1, 2023

Fix/refactor dynamo ipex backend #93863

Closed

Update on "Fix/refactor dynamo onnxrt backend"

97441de

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

This was referenced Feb 1, 2023

Fix/refactor dynamo tvm backend #93870

Closed

Remove torch/_dynamo/optimizations #93871

Closed

Tag dynamo backends as debug/experimental #93878

Closed

jansel added 2 commits February 1, 2023 21:35

Update on "Fix/refactor dynamo onnxrt backend"

936638f

Fixes #90352 cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

Update on "Fix/refactor dynamo onnxrt backend"

5ba23c7

Fixes #90352 cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

jansel requested a review from voznesenskym February 2, 2023 05:43

Update on "Fix/refactor dynamo onnxrt backend"

3db5a76

Fixes #90352 cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

Update on "Fix/refactor dynamo onnxrt backend"

8bb27b2

Fixes #90352 cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

voznesenskym reviewed Feb 2, 2023

View reviewed changes

voznesenskym approved these changes Feb 2, 2023

View reviewed changes

jansel added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 3, 2023

jansel mentioned this pull request Feb 3, 2023

[Dynamo] modify IPEX backend (copy of #92067) #94028

Closed

Update on "Fix/refactor dynamo onnxrt backend"

b6be010

Fixes #90352 cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

Update on "Fix/refactor dynamo onnxrt backend"

94cb764

Fixes #90352 cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]

pytorchmergebot added the Merged label Feb 3, 2023

pytorchmergebot closed this in a5ff400 Feb 3, 2023

facebook-github-bot deleted the gh/jansel/34/head branch June 8, 2023 17:27

		return wrapper


		def device_from_inputs(example_inputs) -> torch.device:

Conversation

jansel commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93818

❌ 1 Failures

Uh oh!

voznesenskym Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

jansel Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

voznesenskym Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

voznesenskym Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

jansel commented Feb 3, 2023

Uh oh!

pytorchmergebot commented Feb 3, 2023

Merge started

Uh oh!

pytorchmergebot commented Feb 3, 2023

Merge failed

Uh oh!

jansel commented Feb 3, 2023

Uh oh!

pytorchmergebot commented Feb 3, 2023

Merge started

Uh oh!

pytorchmergebot commented Feb 3, 2023

Merge failed

Uh oh!

jansel commented Feb 3, 2023

Uh oh!

pytorchmergebot commented Feb 3, 2023

Merge started

Uh oh!

pytorchmergebot commented Feb 3, 2023

Merge failed

Uh oh!

jansel commented Feb 3, 2023

Uh oh!

pytorchmergebot commented Feb 3, 2023

Merge started

Uh oh!

pytorchmergebot commented Feb 3, 2023

Merge failed

Uh oh!

jansel commented Feb 3, 2023

Uh oh!

pytorchmergebot commented Feb 3, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jansel commented Feb 1, 2023 •

edited

Loading

pytorch-bot bot commented Feb 1, 2023 •

edited

Loading