Guard gloo algorithm creation with DeviceGuard#9371
Closed
Conversation
pietern
approved these changes
Jul 12, 2018
Contributor
pietern
left a comment
There was a problem hiding this comment.
Nice catch! It must be a call to cudaMallocHost in Gloo that triggers creation of that context. There are no other allocations/interactions happening with CUDA for the creation of algorithms that have just a single input pointer (as is the case here).
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pietern is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Let us avoid creating a context on GPU0 unnecessarily. Pull Request resolved: pytorch#9371 Reviewed By: pietern Differential Revision: D8817343 Pulled By: apaszke fbshipit-source-id: a6cc91a1dd127840486a42c64f97f117475b0d5f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let us avoid creating a context on GPU0 unnecessarily.