[WIP] [Caffe2] A reasonable way to detect Python include dirs and library#9361
Closed
pjh5 wants to merge 2 commits intopytorch:masterfrom
Closed
[WIP] [Caffe2] A reasonable way to detect Python include dirs and library#9361pjh5 wants to merge 2 commits intopytorch:masterfrom
pjh5 wants to merge 2 commits intopytorch:masterfrom
Conversation
Contributor
Author
|
cc @ezyang who had comments on the last change I made to Python detection |
orionr
approved these changes
Jul 12, 2018
ezyang
reviewed
Jul 13, 2018
| endif() | ||
| endif(NOT DEFINED PYTHON_LIBRARY) | ||
|
|
||
| # These should fill in the rest of the variables, like versions, but resepct |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pjh5 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: Pull Request resolved: pytorch/pytorch#9361 Reviewed By: ml7 Differential Revision: D8837706 Pulled By: pjh5 fbshipit-source-id: 6979f9f37709c23e72b9169531787a60f3b37254
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: Pull Request resolved: pytorch/pytorch#9361 Reviewed By: ml7 Differential Revision: D8837706 Pulled By: pjh5 fbshipit-source-id: 6979f9f37709c23e72b9169531787a60f3b37254
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9361 Reviewed By: ml7 Differential Revision: D8837706 Pulled By: pjh5 fbshipit-source-id: 6979f9f37709c23e72b9169531787a60f3b37254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.