[codemod] Remove virtual+override anti-pattern#9335
Closed
goldsborough wants to merge 1 commit intopytorch:masterfrom
Closed
[codemod] Remove virtual+override anti-pattern#9335goldsborough wants to merge 1 commit intopytorch:masterfrom
goldsborough wants to merge 1 commit intopytorch:masterfrom
Conversation
7745f02 to
c8be0d6
Compare
apaszke
approved these changes
Jul 11, 2018
Contributor
apaszke
left a comment
There was a problem hiding this comment.
Eh... fiiiiiine. I always forget that override implies virtual, but maybe it's just me 😄
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
d23205c to
a5002fb
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@goldsborough is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
a5002fb to
133cfe2
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@goldsborough is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: I'm cramming through clang tidy emitted warnings. This PR addresses the `hi-cpp-override` check which warns that `virtual` + `override` is redundant, since `override` already signifies that a function is overriding and thus virtual. Where there was `virtual` + `override` I removed the `virtual`, where there was `virtual` and no `override` I removed `virtual` and added `override`. ezyang apaszke Pull Request resolved: pytorch/pytorch#9335 Differential Revision: D8807082 Pulled By: goldsborough fbshipit-source-id: e0a261053f6540a22cc56ec160a24aa285af6319
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: I'm cramming through clang tidy emitted warnings. This PR addresses the `hi-cpp-override` check which warns that `virtual` + `override` is redundant, since `override` already signifies that a function is overriding and thus virtual. Where there was `virtual` + `override` I removed the `virtual`, where there was `virtual` and no `override` I removed `virtual` and added `override`. ezyang apaszke Pull Request resolved: pytorch/pytorch#9335 Differential Revision: D8807082 Pulled By: goldsborough fbshipit-source-id: e0a261053f6540a22cc56ec160a24aa285af6319
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: I'm cramming through clang tidy emitted warnings. This PR addresses the `hi-cpp-override` check which warns that `virtual` + `override` is redundant, since `override` already signifies that a function is overriding and thus virtual. Where there was `virtual` + `override` I removed the `virtual`, where there was `virtual` and no `override` I removed `virtual` and added `override`. ezyang apaszke Pull Request resolved: pytorch#9335 Differential Revision: D8807082 Pulled By: goldsborough fbshipit-source-id: e0a261053f6540a22cc56ec160a24aa285af6319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm cramming through clang tidy emitted warnings. This PR addresses the
hi-cpp-overridecheck which warns thatvirtual+overrideis redundant, sinceoverridealready signifies that a function is overriding and thus virtual.Where there was
virtual+overrideI removed thevirtual, where there wasvirtualand nooverrideI removedvirtualand addedoverride.@ezyang @apaszke