[Caffe2] Move tanh function to math#9328
Closed
xiaomengy wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
3f44831 to
fda58df
Compare
houseroad
approved these changes
Jul 10, 2018
Member
houseroad
left a comment
There was a problem hiding this comment.
LGTM! Thanks for cleaning the code.
Member
|
Let's wait for the CI... |
fda58df to
348ce36
Compare
348ce36 to
da17473
Compare
Summary: Pull Request resolved: pytorch#9328 Move tanh function to math Differential Revision: D8794745 fbshipit-source-id: 3bb01480e02d690b416edc1652f559e4fbb8fdb5
da17473 to
d149fa7
Compare
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9328 Move tanh function to math Reviewed By: houseroad Differential Revision: D8794745 fbshipit-source-id: ea525dedde6f53592b06c2caffd6426688dea5fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Move tanh function to math
Differential Revision: D8794745