Add Upsample support in C2 onnx backend for opset 1#9327
Closed
houseroad wants to merge 2 commits intopytorch:masterfrom
Closed
Add Upsample support in C2 onnx backend for opset 1#9327houseroad wants to merge 2 commits intopytorch:masterfrom
houseroad wants to merge 2 commits intopytorch:masterfrom
Conversation
yinghai
reviewed
Jul 10, 2018
| raise ValueError("The first two elements in the scales argument must be 1") | ||
| c2_op.arg.extend([caffe2.python.utils.MakeArgument('height_scale', n.attrs['scales'][2])]) | ||
| c2_op.arg.extend([caffe2.python.utils.MakeArgument('width_scale', n.attrs['scales'][3])]) | ||
| if opset_version >= 7: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
caffe2/onnx/backend.cc
Outdated
|
|
||
| return c2_op; | ||
| if (opset_version >= 7) { | ||
| auto scales = attributes.get<::google::protobuf::RepeatedField<float>>("scales"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
yinghai
approved these changes
Jul 11, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9327 Reviewed By: ailzhang Differential Revision: D8798462 Pulled By: houseroad fbshipit-source-id: d7d1127a853de6a7bb8fdef146f283487e1e5569
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.