Skip to content

Added support for multidimensional tensors in PReLU#932

Closed
goelhardik wants to merge 2 commits intopytorch:masterfrom
goelhardik:issue-724
Closed

Added support for multidimensional tensors in PReLU#932
goelhardik wants to merge 2 commits intopytorch:masterfrom
goelhardik:issue-724

Conversation

@goelhardik
Copy link
Copy Markdown
Contributor

@goelhardik goelhardik commented Mar 5, 2017

Fixes #724
Also, for tensors with more than 1 dimension, the number of PReLU channels is now to be input in the second tensor dimension.

soumith
soumith requested changes Mar 7, 2017
View reviewed changes
Comment thread torch/lib/THCUNN/generic/PReLU.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread torch/lib/THCUNN/generic/PReLU.cu Outdated

This comment was marked as off-topic.

Sign in to view

@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Mar 7, 2017

Made some comments inline. Logically, PR looks good.

@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Mar 7, 2017

Also, add a test case for PReLU 3d in test_nn.py

@goelhardik
Copy link
Copy Markdown
Contributor Author

goelhardik commented Mar 7, 2017

I have added a basic PReLU test that tests the forward and backward pass. If you had any other ideas, please let me know.

@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Mar 7, 2017

@pytorchbot add to whitelist

soumith
soumith reviewed Mar 7, 2017
View reviewed changes
Comment thread test/test_nn.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@goelhardik
Copy link
Copy Markdown
Contributor Author

goelhardik commented Mar 8, 2017

Should be ready, I suppose

@soumith soumith added the ready for review (this tag is deprecated) All PRs are ready for review unless they are draft, WIP, or have undismissed requested changes label Mar 13, 2017
apaszke
apaszke reviewed Mar 22, 2017
View reviewed changes
Comment thread test/test_nn.py Outdated

This comment was marked as off-topic.

Sign in to view

@apaszke apaszke added requested-changes and removed ready for review (this tag is deprecated) All PRs are ready for review unless they are draft, WIP, or have undismissed requested changes labels Mar 22, 2017
@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Mar 22, 2017

I've rebased this branch to only have tests. The other changes are coming through subtree updates from respective upstreams in THNN / THCUNN

@pytorchbot pytorchbot added ready for review (this tag is deprecated) All PRs are ready for review unless they are draft, WIP, or have undismissed requested changes and removed requested changes labels Mar 23, 2017
@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Mar 23, 2017

merged into master via 6b7aef6

Thanks a lot Hardik!

@soumith soumith closed this Mar 23, 2017
jjsjann123 pushed a commit to jjsjann123/pytorch that referenced this pull request Aug 5, 2021
@csarofeen
Reduce preducate redundancy by removing old p2c root map and use comp…
1e48bdf 
…uteAtMap. (pytorch#932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soumith soumith soumith approved these changes

+1 more reviewer

@apaszke apaszke apaszke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source ready for review (this tag is deprecated) All PRs are ready for review unless they are draft, WIP, or have undismissed requested changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support 5D tensors in PReLU

5 participants

@goelhardik @soumith @apaszke @ezyang @pytorchbot