Skip to content

Add cudnn install 8.7.0.84 for CUDA 11.8 #93086

Closed
atalman wants to merge 3 commits intopytorch:masterfrom
atalman:cudnn87_periodic
Closed

Add cudnn install 8.7.0.84 for CUDA 11.8 #93086
atalman wants to merge 3 commits intopytorch:masterfrom
atalman:cudnn87_periodic

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Jan 26, 2023 •
edited
Loading

Add cudnn install 8.7.0.84 for CUDA 11.8 .

Same as: #84964
Related to pytorch/builder#1271
Test PR: #92971

@atalman atalman requested a review from jeffdaily as a code owner January 26, 2023 19:23
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 26, 2023
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93086

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures

As of commit d3a2a15:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Jan 26, 2023

Related to pytorch/builder#1271

@atalman atalman added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Jan 26, 2023
@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Jan 27, 2023

@pytorchbot merge -f "failures are not related"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 27, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jan 27, 2023

@pytorchbot revert -m "Failures are related" -c ignoredsignal

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jan 27, 2023

@atalman can you please elaborate, why you though that signal from 11.8 tests is unrelated to PR that makes changes to 11.8 config? Also, you've forgot to add ciflow/trunk which now contains majority of 11.8 testing, isn't it?
See https://hud.pytorch.org/hud/pytorch/pytorch/master/1?per_page=50&name_filter=cuda11.8

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 27, 2023

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 27, 2023

@atalman your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jan 27, 2023
@pytorchmergebot
Revert "Add cudnn install 8.7.0.84 for CUDA 11.8 (#93086)"
62aa4e0 
This reverts commit 3a10bf7.

Reverted #93086 on behalf of https://github.com/malfet due to Failures are related
@atalman atalman reopened this Jan 27, 2023
@atalman atalman added ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries Trigger all binary build and upload jobs on the PR labels Jan 27, 2023
@ataa ataa mentioned this pull request Jan 29, 2023
Closed
@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Jan 30, 2023 •
edited
Loading

Reason of initial failure failing cudnn build since cudnn was missing from s3:
https://github.com/pytorch/pytorch/actions/runs/4026548941/jobs/6921196025#step:5:18599

Changed to use same path as in: pytorch/builder@3629a05

@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Jan 30, 2023

@pytorchmergebot merge -f "linuxfocal and ios failures are not related"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 30, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category with-ssh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @pytorchmergebot @malfet @kit1980