Remove HTML tags from README.md#9296
Closed
thiagocrepaldi wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
This change makes README.md compatible with both Github and VSTS markdown engines. Images can be reduced if necessary
Collaborator
|
we prefer to keep the HTML tags for image resizing (the table changes look fine). It makes the README prettier for Github. What exactly is the motivation to add markdown processing support for VSTS? |
Collaborator
Author
|
We are beginning to support Pytorch and as a result, we imported Pytorch on VSTS to have a full blown CI. We intend to push everything we can back to Github, but if some patches are not accepted by maintainers but are needed internally, we will keep a fork for internal use until we get another patch that is accepted upstream. The current README.md doesn't work on VSTS due to the URL, which motivated this change.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Soumith Chintala <notifications@github.com>
Sent: Tuesday, July 10, 2018 06:26
To: pytorch/pytorch
Cc: Thiago Crepaldi; Author
Subject: Re: [pytorch/pytorch] Remove HTML tags from README.md (#9296)
we prefer to keep the HTML tags for image resizing (the table changes look fine). It makes the README prettier for Github.
What exactly is the motivation to add markdown processing support for VSTS?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpytorch%2Fpytorch%2Fpull%2F9296%23issuecomment-403821055&data=02%7C01%7Cthiago.crepaldi%40microsoft.com%7Cfafb3acd261f4ac0d1df08d5e668cf0c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636668260179262441&sdata=Ta6bQs9Tg3u2ej2yoC5wUtRnWxGX96HcbVEbKINlpXM%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFN2cafiTTOzofH8rLXab-BLLLEvhsu4ks5uFKuggaJpZM4VIw9K&data=02%7C01%7Cthiago.crepaldi%40microsoft.com%7Cfafb3acd261f4ac0d1df08d5e668cf0c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636668260179262441&sdata=pPic1BN7vRNEaLPM3G6oUiAF%2B5JAwPsFIOZdTSxA%2FXc%3D&reserved=0>.
|
Contributor
|
@soumith What do you think about adding resized copies of the image to somewhere not in GitHub? |
soumith
approved these changes
Jul 17, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
thanks @thiagocrepaldi . We'll merge this and resize our images manually. |
Collaborator
Author
|
Thanks, folks ! |
goldsborough
pushed a commit
to goldsborough/pytorch
that referenced
this pull request
Jul 20, 2018
Summary: This change makes README.md compatible with both Github and VSTS markdown engines. Images can be reduced if necessary Pull Request resolved: pytorch#9296 Differential Revision: D8874931 Pulled By: soumith fbshipit-source-id: 0c530c1e00b06fc891301644c92c33007060bf27
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: This change makes README.md compatible with both Github and VSTS markdown engines. Images can be reduced if necessary Pull Request resolved: pytorch#9296 Differential Revision: D8874931 Pulled By: soumith fbshipit-source-id: 0c530c1e00b06fc891301644c92c33007060bf27
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This change makes README.md compatible with both Github and VSTS markdown engines. Images can be reduced if necessary Pull Request resolved: pytorch#9296 Differential Revision: D8874931 Pulled By: soumith fbshipit-source-id: 0c530c1e00b06fc891301644c92c33007060bf27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes README.md compatible with both Github and VSTS markdown engines. Images can be reduced if necessary