Skip to content

[BE][CI] rename .jenkins to .ci, add symlink#92621

Closed
janeyx99 wants to merge 4 commits intogh/janeyx99/9/basefrom
gh/janeyx99/9/head
Closed

[BE][CI] rename .jenkins to .ci, add symlink#92621
janeyx99 wants to merge 4 commits intogh/janeyx99/9/basefrom
gh/janeyx99/9/head

Conversation

@janeyx99
Copy link
Copy Markdown
Contributor

@janeyx99 janeyx99 commented Jan 19, 2023 •
edited
Loading

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 19, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92621

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 2aa1793:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Jan 19, 2023
This was referenced Jan 19, 2023
Closed
Closed
@janeyx99 janeyx99 mentioned this pull request Jan 19, 2023
Closed
@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Jan 19, 2023

To enable symlink support for Windows https://github.com/pytorch/pytorch/blob/master/.github/workflows/_win-test.yml#L61-L64

@janeyx99 janeyx99 requested a review from a team as a code owner January 19, 2023 19:21
ZainRizvi
ZainRizvi previously approved these changes Jan 19, 2023
View reviewed changes
@ZainRizvi ZainRizvi self-requested a review January 19, 2023 22:19
@ZainRizvi ZainRizvi dismissed their stale review January 19, 2023 22:19

more q's

janeyx99 added a commit that referenced this pull request Jan 20, 2023
@janeyx99
[BE][CI] rename .jenkins to .ci, add symlink
a305903 
ghstack-source-id: 6c1114e
Pull Request resolved: #92621
@janeyx99 janeyx99 added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 20, 2023
@janeyx99
Copy link
Copy Markdown
Contributor Author

janeyx99 commented Jan 20, 2023

Adding ciflow/trunk label to make sure things will pass.

Will force merge later if the only thing I'm bypassing is the pr-sanity-check.

@janeyx99
Copy link
Copy Markdown
Contributor Author

janeyx99 commented Jan 21, 2023

@pytorchbot merge -f "sanity check is incorrect, other failures are preexisting"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 21, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Jan 23, 2023

@pytorchbot revert -m "breaks shipit" -c ghfirst

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 23, 2023

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 23, 2023

@janeyx99 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jan 23, 2023
@pytorchmergebot
Revert "[BE][CI] rename .jenkins to .ci, add symlink (#92621)"
afe6ea8 
This reverts commit 8972a9f.

Reverted #92621 on behalf of https://github.com/atalman due to breaks shipit
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jan 23, 2023

@bigfootjon can you please check what is going on there?

@janeyx99 janeyx99 reopened this Jan 23, 2023
@janeyx99
Copy link
Copy Markdown
Contributor Author

janeyx99 commented Jan 23, 2023

will open another PR instead

@janeyx99 janeyx99 closed this Jan 23, 2023
@janeyx99 janeyx99 mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@ZainRizvi ZainRizvi ZainRizvi approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: releng release notes category Reverted skip-pr-sanity-checks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@janeyx99 @huydhn @pytorchmergebot @atalman @malfet @ZainRizvi