Fix the build break for python3.7 PyUnicode_AsUTF8AndSize() prototype changing#9259
Closed
JerryShih wants to merge 1 commit intopytorch:masterfrom
Closed
Fix the build break for python3.7 PyUnicode_AsUTF8AndSize() prototype changing#9259JerryShih wants to merge 1 commit intopytorch:masterfrom
JerryShih wants to merge 1 commit intopytorch:masterfrom
Conversation
… changing. https://docs.python.org/3.7/c-api/unicode.html#c.PyUnicode_AsUTF8AndSize The return type changes from "char*" to "const char*".
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pjh5 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
orionr
approved these changes
Jul 11, 2018
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
… changing (pytorch#9259) Summary: https://docs.python.org/3.7/c-api/unicode.html#c.PyUnicode_AsUTF8AndSize The return type changes from "char*" to "const char*". Pull Request resolved: pytorch#9259 Reviewed By: orionr Differential Revision: D8776219 Pulled By: pjh5 fbshipit-source-id: e5eadf71264002ba57cfb68dd39686a7ec074092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3.7/c-api/unicode.html#c.PyUnicode_AsUTF8AndSize
The return type changes from "char*" to "const char*".