Skip to content

Fix gatherTopK template#9231

Closed
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:fix_gather_top_k_template
Closed

Fix gatherTopK template#9231
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:fix_gather_top_k_template

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jul 7, 2018

Summary: Fix gatherTopK template
This change makes it possible to instantiate getherTopK() with IndecesType other than caffe2::TIndex

Summary: Fix gatherTopK template
This change makes it possible to instantiate getherTopK() with IndecesType other than caffe2::TIndex
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
Summary:
Fix gatherTopK template
This change makes it possible to instantiate getherTopK() with IndecesType other than caffe2::TIndex
Pull Request resolved: pytorch#9231

Reviewed By: houseroad

Differential Revision: D8886778

Pulled By: malfet

fbshipit-source-id: d5fb1f8814710cd81bc0cf65e0f96fd9fd8317da
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
Fix gatherTopK template
This change makes it possible to instantiate getherTopK() with IndecesType other than caffe2::TIndex
Pull Request resolved: pytorch#9231

Reviewed By: houseroad

Differential Revision: D8886778

Pulled By: malfet

fbshipit-source-id: d5fb1f8814710cd81bc0cf65e0f96fd9fd8317da
@ezyang ezyang added the merged label Jun 26, 2019
@malfet malfet deleted the fix_gather_top_k_template branch April 17, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants