Fix RoIAlignOp GPU implementation for RoIs without batch index#9230
Closed
malfet wants to merge 1 commit intopytorch:masterfrom
Closed
Fix RoIAlignOp GPU implementation for RoIs without batch index#9230malfet wants to merge 1 commit intopytorch:masterfrom
malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: Fix RoIAlignOp GPU implementation for RoIs without batch index According to https://caffe2.ai/docs/operators-catalogue.html#roialign, RoIs is "2D input of shape (R, 4 or 5)" Pass RoIs 2nd dimension as kernel parameter and adjust kernel accordingly
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
…ch#9230) Summary: Fix RoIAlignOp GPU implementation for RoIs without batch index According to https://caffe2.ai/docs/operators-catalogue.html#roialign, RoIs is "2D input of shape (R, 4 or 5)" Pass RoIs 2nd dimension as kernel parameter and adjust kernel accordingly Pull Request resolved: pytorch#9230 Reviewed By: houseroad Differential Revision: D8886798 Pulled By: malfet fbshipit-source-id: 52a8b4df85f7e350e36c842ee4428f3a1cba2588
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…ch#9230) Summary: Fix RoIAlignOp GPU implementation for RoIs without batch index According to https://caffe2.ai/docs/operators-catalogue.html#roialign, RoIs is "2D input of shape (R, 4 or 5)" Pass RoIs 2nd dimension as kernel parameter and adjust kernel accordingly Pull Request resolved: pytorch#9230 Reviewed By: houseroad Differential Revision: D8886798 Pulled By: malfet fbshipit-source-id: 52a8b4df85f7e350e36c842ee4428f3a1cba2588
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fix RoIAlignOp GPU implementation for RoIs without batch index
According to https://caffe2.ai/docs/operators-catalogue.html#roialign, RoIs is "2D input of shape (R, 4 or 5)"
Pass RoIs 2nd dimension as kernel parameter and adjust kernel accordingly