[EASY] Allow passing '0' to ASAN/UBSAN flags#9202
Closed
yf225 wants to merge 1 commit intopytorch:masterfrom
Closed
[EASY] Allow passing '0' to ASAN/UBSAN flags#9202yf225 wants to merge 1 commit intopytorch:masterfrom
yf225 wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Jul 6, 2018
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Similar to pytorch#9187, This PR makes setting the `PYTORCH_TEST_WITH_ASAN` and `PYTORCH_TEST_WITH_UBSAN` flags easier internally, by allowing the flags to be set to `0`. Closes pytorch#9202 Differential Revision: D8745533 Pulled By: yf225 fbshipit-source-id: 6293f52f2e8b1c3ef150becfdc2dd7ded56d5d80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #9187, This PR makes setting the
PYTORCH_TEST_WITH_ASANandPYTORCH_TEST_WITH_UBSANflags easier internally, by allowing the flags to be set to0.