Closed
Conversation
This file was added in pytorch#9107 but wasn't installed. The libraries in ./torch/lib use the headers from Caffe2/ATen from their temporary install path at torch/lib/tmp_install, and c10d was not able to find THC/THCGeneral.hpp before this fix.
Contributor
Author
|
This is a quick fix for a c10d build failure if NCCL is enabled. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pietern has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 4, 2018
Summary: This file was added in #9107 but wasn't installed. The libraries in ./torch/lib use the headers from Caffe2/ATen from their temporary install path at torch/lib/tmp_install, and c10d was not able to find THC/THCGeneral.hpp before this fix. Closes pytorch/pytorch#9159 Reviewed By: Yangqing Differential Revision: D8731107 Pulled By: pietern fbshipit-source-id: d6009f6f6e8e6e0f37dea24cc4c3570736943ab1
Collaborator
|
duplicate of #9159 |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: This file was added in #9107 but wasn't installed. The libraries in ./torch/lib use the headers from Caffe2/ATen from their temporary install path at torch/lib/tmp_install, and c10d was not able to find THC/THCGeneral.hpp before this fix. Closes pytorch/pytorch#9159 Reviewed By: Yangqing Differential Revision: D8731107 Pulled By: pietern fbshipit-source-id: d6009f6f6e8e6e0f37dea24cc4c3570736943ab1
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This file was added in pytorch#9107 but wasn't installed. The libraries in ./torch/lib use the headers from Caffe2/ATen from their temporary install path at torch/lib/tmp_install, and c10d was not able to find THC/THCGeneral.hpp before this fix. Closes pytorch#9159 Reviewed By: Yangqing Differential Revision: D8731107 Pulled By: pietern fbshipit-source-id: d6009f6f6e8e6e0f37dea24cc4c3570736943ab1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file was added in #9107 but wasn't installed. The libraries in
./torch/lib use the headers from Caffe2/ATen from their temporary
install path at torch/lib/tmp_install, and c10d was not able to find
THC/THCGeneral.hpp before this fix.