Skip to content

Fix bug in flip()#9156

Closed
vishwakftw wants to merge 1 commit intopytorch:masterfrom
vishwakftw:flip-bug-fix
Closed

Fix bug in flip()#9156
vishwakftw wants to merge 1 commit intopytorch:masterfrom
vishwakftw:flip-bug-fix

Conversation

@vishwakftw
Copy link
Contributor

@vishwakftw vishwakftw commented Jul 4, 2018

Closes #9147
Added a test to prevent regression in test_torch
Added entries in docs

cc @ezyang @weiyangfb

Closes pytorch#9147
Added a test to prevent regression in test_torch
Added entries in docs
@ssnl
Copy link
Collaborator

ssnl commented Jul 4, 2018

Not familiar with flip() logic. Can you review? @weiyangfb

auto indices = std::vector<at::Tensor>(flip_dims_size);
for (int64_t i = 0; i < flip_dims_size; i++) {
indices[i] = at::arange(self.size(i) - 1, -1, -1, self.type().toScalarType(at::kLong));
indices[i] = at::arange(self.size(flip_dims_v[i]) - 1, -1, -1, self.type().toScalarType(at::kLong));

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soumith has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@vishwakftw vishwakftw deleted the flip-bug-fix branch July 4, 2018 14:28
zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 4, 2018
Summary:
Closes #9147
Added a test to prevent regression in test_torch
Added entries in docs

cc ezyang weiyangfb
Closes pytorch/pytorch#9156

Differential Revision: D8732095

Pulled By: soumith

fbshipit-source-id: 7a6892853cfc0ccb0142b4fd25015818849adf61
zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 13, 2018
Summary:
Closes #9147
Added a test to prevent regression in test_torch
Added entries in docs

cc ezyang weiyangfb
Closes pytorch/pytorch#9156

Differential Revision: D8732095

Pulled By: soumith

fbshipit-source-id: 7a6892853cfc0ccb0142b4fd25015818849adf61
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
Closes pytorch#9147
Added a test to prevent regression in test_torch
Added entries in docs

cc ezyang weiyangfb
Closes pytorch#9156

Differential Revision: D8732095

Pulled By: soumith

fbshipit-source-id: 7a6892853cfc0ccb0142b4fd25015818849adf61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug in running flip() on cpu

7 participants