loss plugin: Fix indexing into a scalar#9143
Closed
rfejgin wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
The loss plugin was using the old-style loss[0] access, which in PyTorch 0.4 and later is an attempt to index into a scalar, generating a warning. Replaced that with loss.item(). This fixes pytorch#9142
soumith
approved these changes
Jul 3, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: The loss plugin was using the old-style loss[0] access, which in PyTorch 0.4 and later is an attempt to index into a scalar, generating a warning. Replaced that with loss.item(). This fixes pytorch#9142 Closes pytorch#9143 Differential Revision: D8726403 Pulled By: ezyang fbshipit-source-id: 6c496b140a74d22c8423f511db901b18615fd6fa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loss plugin was using the old-style loss[0] access, which in PyTorch 0.4 and
later is an attempt to index into a scalar, generating a warning.
Replaced that with loss.item().
This fixes
#9142