[FSDP][Easy] Fix context manager syntax#91410
Closed
awgu wants to merge 1 commit intogh/awgu/287/basefrom
Closed
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91410
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 112794c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
Let's wait with merging this until we understand what's going on with #91371 so we don't mask the symptoms. |
kit1980
approved these changes
Dec 28, 2022
Contributor
|
@pytorchbot merge -f "Unrelated ios failure" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
replicateinfully_shard#91044 [FSDP][7/N] Supportreplicateinfully_shard_FSDPStatetraversal #90959 [FSDP][6/N] Add note explaining idioms for_FSDPStatetraversalfully_shard#90874 [FSDP][5/N] Add manual "wrapping" support forfully_shard