Add some missing error checks in sparse.#9140
Closed
ezyang wants to merge 6 commits intopytorch:masterfrom
Closed
Conversation
- There were missing error messages for AT_CHECK in SparseTensorImpl::set_indices_and_values - We have to check that the backends of all our inputs line up, since native does not do it for us. - Some math operations were missing shape tests. Fixes pytorch#9110 Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
ssnl
approved these changes
Jul 3, 2018
| AT_CHECK(t.size(1) == dim_k, | ||
| "Argument #1 (t): Expected dim 1 size ", dim_k, ", got ", t.size(1)); | ||
|
|
||
| r.resize_({dim_i, dim_k}); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| } | ||
|
|
||
| AT_CHECK(_is_same_density(t, src), "cadd operands have incompatible desnitities"); | ||
| AT_CHECK(_is_same_density(t, src), "cadd operands have incompatible densities"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ssnl
reviewed
Jul 3, 2018
| r_.copy_(dense); | ||
| } else { | ||
| AT_CHECK(r_.is_contiguous(), "CUDA dense-sparse addition known bug"); | ||
| AT_CHECK(r_.is_contiguous(), "add: CUDA dense-sparse addition does not work; shout if you need it"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 3, 2018
Summary: - There were missing error messages for AT_CHECK in SparseTensorImpl::set_indices_and_values - We have to check that the backends of all our inputs line up, since native does not do it for us. - Some math operations were missing shape tests. Fixes #9110 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Closes pytorch/pytorch#9140 Differential Revision: D8724349 Pulled By: ezyang fbshipit-source-id: 3c75104187aca97cbe92bb0ec24f6ded07b2c3d6
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: - There were missing error messages for AT_CHECK in SparseTensorImpl::set_indices_and_values - We have to check that the backends of all our inputs line up, since native does not do it for us. - Some math operations were missing shape tests. Fixes #9110 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Closes pytorch/pytorch#9140 Differential Revision: D8724349 Pulled By: ezyang fbshipit-source-id: 3c75104187aca97cbe92bb0ec24f6ded07b2c3d6
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: - There were missing error messages for AT_CHECK in SparseTensorImpl::set_indices_and_values - We have to check that the backends of all our inputs line up, since native does not do it for us. - Some math operations were missing shape tests. Fixes pytorch#9110 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Closes pytorch#9140 Differential Revision: D8724349 Pulled By: ezyang fbshipit-source-id: 3c75104187aca97cbe92bb0ec24f6ded07b2c3d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since native does not do it for us.
Fixes #9110
Signed-off-by: Edward Z. Yang ezyang@fb.com