Move easy THStorage functions out of generic.#9135
Closed
ezyang wants to merge 1 commit intopytorch:masterfrom
Closed
Move easy THStorage functions out of generic.#9135ezyang wants to merge 1 commit intopytorch:masterfrom
ezyang wants to merge 1 commit intopytorch:masterfrom
Conversation
I didn't move any functions which actually needed to generate real-specific code. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gchanan
approved these changes
Jul 3, 2018
| void THStorage_retain(THStorage *storage) | ||
| { | ||
| if(storage && (storage->flag & TH_STORAGE_REFCOUNTED)) | ||
| ++storage->refcount; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
Rolled into #9136 |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Some functions are exactly implemented in THStorage_; in that case, we called those functions directly. Stacked on pytorch#9135 Closes pytorch#9136 Reviewed By: Yangqing Differential Revision: D8723998 Pulled By: ezyang fbshipit-source-id: 653d23a5e1db4b9bdda50641fa97730894cc8ed5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't move any functions which actually needed to generate
real-specific code.
Signed-off-by: Edward Z. Yang ezyang@fb.com