cc: @vadimkantorov

Looks good. Btw, why do we have the gray lines?

The overlay was added in an older PR, so that it made the transition look better. I actually find it a bit confusing. Do you think we should remove them?

what do you thing about adding vertical lines as well? to see clearly where breakpoints happen

This is how it looks with breakpoints.

I have removed the overlay to avoid confusion.

@vadimkantorov I would say that would be too much. We could add some extra ticks on the X axis, but lines are usually asymptotes, and this is not what's happening there. It also adds visual clutter.

we can also just add the grid lines

I agree with @apaszke , the vertical lines cause issues for plots like ReLU6.

This is the current plot for HardTanh

Hope this is fine.

I think at least xticks and yticks on +1 and -1 should be there.

@apaszke @vishwakftw The last one looks good: conveys the meaning of asymptotes and enables grasping where the breakpoints are, if needed + not much visual clutter (but even the grid lines without asymptotes are fine for my taste).

Thanks! Grid lines look a bit too subtle to me. What do you think?

Also, with grid lines, do we still want asymptotic lines?

@ssnl removed asymptote lines and increased the width.

@pytorchbot retest this please