[C++ API] Create Sequential::extend#9116
Closed
goldsborough wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
ebetica
approved these changes
Jul 2, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@goldsborough has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@goldsborough is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: There is no way to concatenate two `Sequential`s in Python, but it's also easier to do in an immutable fashion by just writing `Sequential(first.modules() + second.modules())`. Concatenating vectors isn't as easy in C++, so I think it's fair to save users some for loops by giving them `Sequential::extend()`. apaszke ebetica ezyang CC jamespinkerton Closes pytorch#9116 Reviewed By: ezyang Differential Revision: D8719630 Pulled By: goldsborough fbshipit-source-id: 840d7ac70755350e6202b493c531e30ecbb6546f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no way to concatenate two
Sequentials in Python, but it's also easier to do in an immutable fashion by just writingSequential(first.modules() + second.modules()). Concatenating vectors isn't as easy in C++, so I think it's fair to save users some for loops by giving themSequential::extend().@apaszke @ebetica @ezyang
CC @jamespinkerton