Skip to content

Add test tracking operators without decompositions#90887

Closed
peterbell10 wants to merge 17 commits intogh/peterbell10/474/basefrom
gh/peterbell10/474/head
Closed

Add test tracking operators without decompositions#90887
peterbell10 wants to merge 17 commits intogh/peterbell10/474/basefrom
gh/peterbell10/474/head

Conversation

@peterbell10
Copy link
Copy Markdown
Collaborator

@peterbell10 peterbell10 commented Dec 15, 2022

Stack from ghstack (oldest at bottom):

This test inspects the dispatcher directly, so captures operators without
OpInfo including internal helper operators and backward operators that might
appear in a trace.

This test inspects `torch.ops.aten` directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Dec 15, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90887

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit fa6bdac:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This test inspects `torch.ops.aten` directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Dec 15, 2022
This test inspects `torch.ops.aten` directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

ghstack-source-id: 8c0fbb2
Pull Request resolved: #90887
@peterbell10 peterbell10 marked this pull request as ready for review December 15, 2022 14:25
@peterbell10 peterbell10 requested a review from ngimel December 15, 2022 14:26
Copy link
Copy Markdown
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find linalg_solve_triangular in the expected list, but that one has explicit CPU and CUDA dispatches. What's going on there?

This test inspects the dispatcher directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

[ghstack-poisoned]
This test inspects the dispatcher directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

[ghstack-poisoned]
Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems... fine, I guess? Automatically updating the expect file works right? Cc @SherlockNoMad

This test inspects the dispatcher directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

[ghstack-poisoned]
This test inspects the dispatcher directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

[ghstack-poisoned]
@peterbell10 peterbell10 added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 17, 2023
This test inspects the dispatcher directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Jan 21, 2023
This test inspects `torch.ops.aten` directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

ghstack-source-id: f0a5202
Pull Request resolved: #90887
This test inspects the dispatcher directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Jan 24, 2023
This test inspects `torch.ops.aten` directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

ghstack-source-id: 7728948
Pull Request resolved: #90887
@peterbell10
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Jan 24, 2023

@pytorchbot revert -m 'Sorry for reverting your PR. We reverted #70988 in https://hud.pytorch.org/pytorch/pytorch/commit/acdd462b1a070790799ce4623ce8ecc83e197e81 and this test starts to fail. There is probably a dependency between the twos' -c weird

@pytorch pytorch deleted a comment from pytorch-bot Bot Jan 24, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@peterbell10 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jan 24, 2023
This reverts commit 2740daf.

Reverted #90887 on behalf of https://github.com/huydhn due to Sorry for reverting your PR. We reverted #70988 in https://hud.pytorch.org/pytorch/pytorch/commit/acdd462b1a070790799ce4623ce8ecc83e197e81 and this test starts to fail. There is probably a dependency between the twos
@pytorch pytorch deleted a comment from pytorch-bot Bot Jan 24, 2023
@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Jan 24, 2023

Please do a rebase to master and rerun the tests

peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Jan 24, 2023
This test inspects `torch.ops.aten` directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

ghstack-source-id: 7728948
Pull Request resolved: pytorch#90887
This test inspects the dispatcher directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Jan 24, 2023
This test inspects `torch.ops.aten` directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.

ghstack-source-id: e45f02b
Pull Request resolved: #90887
@peterbell10
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -f "Dynamo failure is pre-existing on master"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/474/head branch June 8, 2023 18:23
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
This test inspects the dispatcher directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.
Pull Request resolved: pytorch#90887
Approved by: https://github.com/ezyang
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
…0887)"

This reverts commit a191a03.

Reverted pytorch#90887 on behalf of https://github.com/huydhn due to Sorry for reverting your PR. We reverted pytorch#70988 in https://hud.pytorch.org/pytorch/pytorch/commit/2f93ceda0cefe43d3e26e30f7cd6e72c22096e0b and this test starts to fail. There is probably a dependency between the twos
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
This test inspects the dispatcher directly, so captures operators without
`OpInfo` including internal helper operators and backward operators that might
appear in a trace.
Pull Request resolved: pytorch#90887
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants