Skip to content

[Caffe2] Add Adadelta optimizer to caffe2#9088

Closed
sidgoyal78 wants to merge 1 commit intopytorch:masterfrom
sidgoyal78:export-D8712169
Closed

[Caffe2] Add Adadelta optimizer to caffe2#9088
sidgoyal78 wants to merge 1 commit intopytorch:masterfrom
sidgoyal78:export-D8712169

Conversation

@sidgoyal78
Copy link
Contributor

@sidgoyal78 sidgoyal78 commented Jul 2, 2018

Summary:

  • Added CPU/GPU implementations of Adadelta and SparseAdadelta.
  • Added corresponding Python unittests

Differential Revision: D8712169

xiaomengy
xiaomengy suggested changes Jul 16, 2018
View reviewed changes
caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@xiaomengy xiaomengy changed the title Add Adadelta optimizer to caffe2 [Caffe2] Add Adadelta optimizer to caffe2 Jul 16, 2018
xiaomengy
xiaomengy reviewed Jul 16, 2018
View reviewed changes
caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

xiaomengy
xiaomengy reviewed Jul 16, 2018
View reviewed changes
caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

xiaomengy
xiaomengy reviewed Jul 16, 2018
View reviewed changes
caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

sidgoyal78
sidgoyal78 commented Jul 17, 2018
View reviewed changes
Copy link
Contributor Author

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. I have modified the implementation accordingly.

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/sgd/adadelta_op.h Outdated

This comment was marked as off-topic.

Sign in to view

@xiaomengy
Copy link
Contributor

xiaomengy commented Jul 18, 2018

@pytorchbot retest this please

xiaomengy
xiaomengy approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@xiaomengy xiaomengy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this effort. I will take care of the next steps for eigen and CUDA optimization

@sidgoyal78
Copy link
Contributor Author

sidgoyal78 commented Jul 19, 2018

@pytorchbot retest this please

2 similar comments
@sidgoyal78
Copy link
Contributor Author

sidgoyal78 commented Jul 19, 2018

@pytorchbot retest this please

@xiaomengy
Copy link
Contributor

xiaomengy commented Jul 19, 2018

@pytorchbot retest this please

xiaomengy
xiaomengy approved these changes Jul 20, 2018
View reviewed changes
caffe2/sgd/adadelta_op_gpu.cu Outdated

This comment was marked as off-topic.

Sign in to view

@sidgoyal78 @facebook-github-bot
Add Adadelta optimizer to caffe2 (pytorch#9088)
c1bec97 
Summary:
Pull Request resolved: pytorch#9088

Closes pytorch#9088

- Added CPU/GPU implementations of Adadelta and SparseAdadelta.
- Added corresponding Python unittests

Differential Revision: D8712169

fbshipit-source-id: f42f79df0038a100f17b900ac676d080b2fce9a0
jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
@sidgoyal78 @jramseyer
Add Adadelta optimizer to caffe2 (pytorch#9088)
121b857 
Summary:
Pull Request resolved: pytorch#9088

Closes pytorch#9088

- Added CPU/GPU implementations of Adadelta and SparseAdadelta.
- Added corresponding Python unittests

Reviewed By: BIT-silence

Differential Revision: D8712169

fbshipit-source-id: 544e99e13b230a919672a7341b3715d64597c0be
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
@sidgoyal78
Add Adadelta optimizer to caffe2 (pytorch#9088)
8ae7e67 
Summary:
Pull Request resolved: pytorch#9088

Closes pytorch#9088

- Added CPU/GPU implementations of Adadelta and SparseAdadelta.
- Added corresponding Python unittests

Reviewed By: BIT-silence

Differential Revision: D8712169

fbshipit-source-id: 544e99e13b230a919672a7341b3715d64597c0be
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xiaomengy xiaomengy xiaomengy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

caffe2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sidgoyal78 @xiaomengy @ezyang @weiyangfb