[EASY] Use a static random_device in StorageSharing#9080
Closed
[EASY] Use a static random_device in StorageSharing#9080
Conversation
yf225
approved these changes
Jul 1, 2018
soumith
approved these changes
Jul 6, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: I've been cleaning up my email notifications, and noticed that this PR used a stack-allocated `random_device`. This is generally a bad idea due to this sentence from the C++ reference (emphasis mine): > `std::random_device` may be implemented in terms of an implementation-defined pseudo-random number engine if a non-deterministic source (e.g. a hardware device) is not available to the implementation. **In this case each `std::random_device` object may generate the same number sequence.** If this is how this object is implemented, then this `rd()` call will give the same result at every call. cc yf225 Closes pytorch#9080 Differential Revision: D8748342 Pulled By: soumith fbshipit-source-id: 22987befee61ff7faacda5ecc10138c2ac5d26ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been cleaning up my email notifications, and noticed that this PR used a stack-allocated
random_device. This is generally a bad idea due to this sentence from the C++ reference (emphasis mine):If this is how this object is implemented, then this
rd()call will give the same result at every call.cc @yf225