[DataLoader2] Fix apply_sharding to accept one sharding_filter per branch#90769
Closed
ejguan wants to merge 3 commits intopytorch:masterfrom
Closed
[DataLoader2] Fix apply_sharding to accept one sharding_filter per branch#90769ejguan wants to merge 3 commits intopytorch:masterfrom
ejguan wants to merge 3 commits intopytorch:masterfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90769
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6db5dd5: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
4 tasks
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Dec 13, 2022
Contributor
NivekT
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this!
NivekT
reviewed
Dec 13, 2022
Contributor
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Dec 14, 2022
Contributor
NivekT
left a comment
There was a problem hiding this comment.
Thanks for updating the error message!
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
to meta-pytorch/data
that referenced
this pull request
Dec 28, 2022
…processing (#919) Summary: This PR is created on top of #555. And, this PR extends `PrototypeMultiprocessingReadingService` to accept non-replicable DataPipe. And, this PR depends on pytorch/pytorch#90769 ### Main Changes - Add a way to launch a process to fetch data from non-replicable DataPipes and send data to worker processes in a round-robin manner - Add `ShardingRoundRobinDispatcher` (functional name `sharding_round_robin_dispatch`) to indicate non-replicable DataPipe - Add `MultipleDataPipesToQueuesLoop` to connect non-sharding process to request/response queues - Add `find_lca_non_replicable_dp` as a graph function to determine the lowest common ancestor of all non-replicabble DataPipes. This would guarantee that all non-replicable DataPipes will be running in a single dispatching process - In each multiprocessing worker process, - If All datapipes are replicable, apply multiprocessing sharding to the graph - If not, worker would use `find_replicable_branches` to apply mp sharding to those replicable branches, because all non-replicable branches have been properly sharded by routing data round-robinly to worker processes. - Properly get `ResetEpochResponse` from protocol via `get_response_reset_epoch` - [x] Add tests for two graph functions - [x] Add test to launch non-shardable DataPipe process - Add documents - [x] Replicable DataPipe/Non-replicable DataPipe in multiprocessing - [x] How PrototypeMPRS handles the above two types of DataPipe Please check the link for doc: https://ejguan.github.io/dataloader2.html#dynamic-sharding ## nit Changes - Rename `Spawn` to `Create` as the process has not been started Pull Request resolved: #919 Reviewed By: wenleix Differential Revision: D42004034 Pulled By: ejguan fbshipit-source-id: 5b0b1cb7c2781c4f45240d21f37d457b9729b9a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
sharding_filterin the pipeline as long as they are not on the same branchExample:
In order to properly shard
DP1andDP2, we should allow multiplesharding_filters