Skip to content

Add support for ArgMax and ArgMin in C2 onnx backend and frontend#9050

Closed
houseroad wants to merge 3 commits intopytorch:masterfrom
houseroad:argmaxmin
Closed

Add support for ArgMax and ArgMin in C2 onnx backend and frontend#9050
houseroad wants to merge 3 commits intopytorch:masterfrom
houseroad:argmaxmin

Conversation

@houseroad
Copy link
Member

Pass the end to end test cases in onnx/onnx#1049

@houseroad houseroad requested review from bddppq and yinghai June 29, 2018 21:55
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad
Copy link
Member Author

@pytorchbot retest this please

1 similar comment
@houseroad
Copy link
Member Author

@pytorchbot retest this please

auto& node = nodes.back();

bool explicit_axis = false;
for (const auto& a : def.arg()) {

This comment was marked as off-topic.

This comment was marked as off-topic.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad
Copy link
Member Author

@pytorchbot retest this please

Copy link
Contributor

@Ac2zoom Ac2zoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! Implementation matches that of similar ops and manifests expected divergences in ONNX vs. Caffe2 specs.

goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
…torch#9050)

Summary:
Pass the end to end test cases in onnx/onnx#1049
Closes pytorch#9050

Reviewed By: hlu1

Differential Revision: D8703757

Pulled By: houseroad

fbshipit-source-id: 63308202e349dfc02d532e87f49495ba1aab085b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants