Closed
Conversation
ezyang
approved these changes
Jun 29, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 29, 2018
Summary: Fix missing functions for MSVC 2015 Inspired by tensorflow/tensorflow#13525 Closes pytorch/pytorch#9023 Reviewed By: soumith Differential Revision: D8694046 Pulled By: ezyang fbshipit-source-id: 92cb7b9efd76d97a264c12a1521be550176f58d5
Collaborator
Author
|
Wait, I just found that this implementation is wrong. I'll make a new PR to fix this. |
Collaborator
|
@peterjc123 landing your other PR, but this PR got merged too. Should we revert this change? |
Collaborator
Author
|
@soumith I guess it's okay. The errors will get overwritten. If you want to cherry-pick, remember to skip this PR. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 10, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: Fix missing functions for MSVC 2015 Inspired by tensorflow/tensorflow#13525 Closes pytorch/pytorch#9023 Reviewed By: soumith Differential Revision: D8694046 Pulled By: ezyang fbshipit-source-id: 92cb7b9efd76d97a264c12a1521be550176f58d5
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Fix missing functions for MSVC 2015 Inspired by tensorflow/tensorflow#13525 Closes pytorch#9023 Reviewed By: soumith Differential Revision: D8694046 Pulled By: ezyang fbshipit-source-id: 92cb7b9efd76d97a264c12a1521be550176f58d5
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Replacement of pytorch#9023. Pull Request resolved: pytorch#9300 Differential Revision: D8781492 Pulled By: soumith fbshipit-source-id: 6c0994da46d3112c24769f92366836c397891d93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing functions for MSVC 2015
Inspired by tensorflow/tensorflow#13525