[functorch] Move cond.py to _cond.py and expose cond() under functorch.experimental.control_flow.#89819
Closed
zhxchen17 wants to merge 1 commit intogh/zhxchen17/44/basefrom
Closed
[functorch] Move cond.py to _cond.py and expose cond() under functorch.experimental.control_flow.#89819zhxchen17 wants to merge 1 commit intogh/zhxchen17/44/basefrom
cond.py to _cond.py and expose cond() under functorch.experimental.control_flow.#89819zhxchen17 wants to merge 1 commit intogh/zhxchen17/44/basefrom
Conversation
…nctorch.experimental.control_flow. Summary: Similar to #88767 we want to reduce the chance that users accidentally import private functions from `functorch.experimental.cond` as if they were public interfaces. We also move `cond()` under `control_flow.py` to stay consistent with `map()` op. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89819
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit 6aec97b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zhxchen17
added a commit
that referenced
this pull request
Nov 29, 2022
…nctorch.experimental.control_flow. Summary: Similar to #88767 we want to reduce the chance that users accidentally import private functions from `functorch.experimental.cond` as if they were public interfaces. We also move `cond()` under `control_flow.py` to stay consistent with `map()` op. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: bcce75d Pull Request resolved: #89819
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…nctorch.experimental.control_flow. (pytorch#89819) Summary: Similar to pytorch#88767 we want to reduce the chance that users accidentally import private functions from `functorch.experimental.cond` as if they were public interfaces. We also move `cond()` under `control_flow.py` to stay consistent with `map()` op. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#89819 Approved by: https://github.com/zou3519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cond.pyto_cond.pyand exposecond()under functorch.experimental.control_flow. #89819Summary:
Similar to #88767 we want to reduce the chance that users
accidentally import private functions from
functorch.experimental.condas if they were publicinterfaces. We also move
cond()undercontrol_flow.pyto stay consistent withmap()op.Test Plan:
CI
Reviewers:
Subscribers:
Tasks:
Tags:
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire