Skip to content

Deprecating DataPipes#89794

Closed
ejguan wants to merge 1 commit intopytorch:masterfrom
ejguan:export-D41563765
Closed

Deprecating DataPipes#89794
ejguan wants to merge 1 commit intopytorch:masterfrom
ejguan:export-D41563765

Conversation

@ejguan
Copy link
Contributor

@ejguan ejguan commented Nov 28, 2022

Summary: per title

Test Plan:
buck2 test buck2 test //caffe2/test:datapipe https://www.internalfb.com/intern/testinfra/testconsole/testrun/6473924589747074/
buck2 test mode/opt //pytorch/data/test:tests

Differential Revision: D41563765


FileLoader was deprecated and now removed. Please use FileOpener instead.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 28, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89794

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6d01e20:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41563765

ejguan added a commit to ejguan/data that referenced this pull request Nov 28, 2022
Summary:
X-link: pytorch/pytorch#89794

Pull Request resolved: meta-pytorch#909

per title

Differential Revision: D41563765

fbshipit-source-id: b0b283ceb63a60aaa25b12a2b0d1b536ff5ccf85
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41563765

@ejguan ejguan requested review from NivekT and wenleix November 29, 2022 01:00
@ejguan
Copy link
Contributor Author

ejguan commented Nov 29, 2022

Somehow the DIff has to be approved from OSS.

Copy link
Contributor

@wenleix wenleix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Summary:
Pull Request resolved: pytorch#89794

X-link: meta-pytorch/data#909

per title

Test Plan:
`buck2 test buck2 test //caffe2/test:datapipe` https://www.internalfb.com/intern/testinfra/testrun/4222124790012281

`buck2 test //pytorch/data/test:tests`

Reviewed By: wenleix, NivekT

Differential Revision: D41563765

fbshipit-source-id: aa934bf87645f31a5ab1cf04beddcc9b910aea82
ejguan added a commit to ejguan/data that referenced this pull request Nov 29, 2022
Summary:
X-link: pytorch/pytorch#89794

Pull Request resolved: meta-pytorch#909

per title

Reviewed By: wenleix, NivekT

Differential Revision: D41563765

fbshipit-source-id: 91c01e433bf0b48a53b42628acc3e056920df283
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41563765

facebook-github-bot pushed a commit to meta-pytorch/data that referenced this pull request Nov 29, 2022
Summary:
X-link: pytorch/pytorch#89794

Pull Request resolved: #909

per title

Reviewed By: wenleix, NivekT

Differential Revision: D41563765

fbshipit-source-id: e5006768cdce9c1da1204b4258a965de5ab1aa38
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 29, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
Summary: per title

Test Plan:
`buck2 test buck2 test //caffe2/test:datapipe` https://www.internalfb.com/intern/testinfra/testconsole/testrun/6473924589747074/
`buck2 test mode/opt //pytorch/data/test:tests`

Differential Revision: D41563765

Pull Request resolved: pytorch#89794
Approved by: https://github.com/wenleix, https://github.com/NivekT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: dataloader release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants